[
https://issues.apache.org/jira/browse/YARN-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053820#comment-15053820
]
Subru Krishnan commented on YARN-4340:
--------------------------------------
[~seanpo03], I ran a few e2e tests on my single box and found the following
small issues:
* Can we have _newInstance_ methods *ReservationListRequest* with just the
_queue_ and _reservationid_ as that will make it easy for the most common cases
* We need a null check for _reservationid_ in *ReservationListRequest*
* I see the reservation being listed even though I give the start time after
the end of the reservation
* Similarly I see the reservation being listed even though I give the end
time before the start of the reservation
* We need to add a check for _endTime > startTime_ in
*ReservationInputValidator*
Can you also unit tests to cover these scenarios.
Thanks!
> Add "list" API to reservation system
> ------------------------------------
>
> Key: YARN-4340
> URL: https://issues.apache.org/jira/browse/YARN-4340
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler, fairscheduler, resourcemanager
> Reporter: Carlo Curino
> Assignee: Sean Po
> Attachments: YARN-4340.v1.patch, YARN-4340.v2.patch,
> YARN-4340.v3.patch, YARN-4340.v4.patch, YARN-4340.v5.patch,
> YARN-4340.v6.patch, YARN-4340.v7.patch, YARN-4340.v8.patch
>
>
> This JIRA tracks changes to the APIs of the reservation system, and enables
> querying the reservation system on which reservation exists by "time-range,
> reservation-id".
> YARN-4420 has a dependency on this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
