[
https://issues.apache.org/jira/browse/YARN-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Vasudev updated YARN-3542:
--------------------------------
Attachment: YARN-3542.004.patch
Uploaded a new patch to address [~sidharta-s]'s comments.
bq. unused imports in CGroupsCpuResourceHandlerImpl
Fixed.
bq. Move these to CGroupsHandler ?
Fixed.
bq. About how shares/cfs_period_us/cfs_quota_us are used : additional
comments/documentation and examples (as unit tests?) would be useful. It took
me a while to trace through the code using some examples.
Added comments on how they're used. I also added a bunch of new unit tests.
bq. Since the class has been marked deprecated, is it necessary to make the
rest of the changes that are included ?
I think the class should exist as is for now - the unit tests for the class
would fail without the changes. We can decide later whether to remove it
entirely.
bq. IMO, all references to LCEResourcesHandler (and sub-classes) should be
removed from LinuxContainerExecutor.
The LCEResourcesHandler is a public API(exposed via yarn-site.xml) - users may
have implemented their own. Removing it would mean breaking backwards
compatibility.
> Re-factor support for CPU as a resource using the new ResourceHandler
> mechanism
> -------------------------------------------------------------------------------
>
> Key: YARN-3542
> URL: https://issues.apache.org/jira/browse/YARN-3542
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Reporter: Sidharta Seethana
> Assignee: Sidharta Seethana
> Priority: Critical
> Attachments: YARN-3542.001.patch, YARN-3542.002.patch,
> YARN-3542.003.patch, YARN-3542.004.patch
>
>
> In YARN-3443 , a new ResourceHandler mechanism was added which enabled easier
> addition of new resource types in the nodemanager (this was used for network
> as a resource - See YARN-2140 ). We should refactor the existing CPU
> implementation ( LinuxContainerExecutor/CgroupsLCEResourcesHandler ) using
> the new ResourceHandler mechanism.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
