Varun Saxena commented on YARN-3586:

Thanks Junping for the patch.
Overall the patch looks good.

A couple of nits :
# Do we need changes in MockNodes ? I do not see runningApps being updated 
Even MockRMApp changes do not seem to be required for the test case added. But 
anyways we have to override these methods so should be fine
# Comment added above the debug log (// Log a debug info if collector address 
is not found.) is not required. I guess debug log itself is self explanatory.

> RM only get back addresses of Collectors that NM needs to know.
> ---------------------------------------------------------------
>                 Key: YARN-3586
>                 URL: https://issues.apache.org/jira/browse/YARN-3586
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager, timelineserver
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Critical
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-3586-demo.patch, YARN-3586-feature-YARN-2928.patch
> After YARN-3445, RM cache runningApps for each NM. So RM heartbeat back to NM 
> should only include collectors' address for running applications against 
> specific NM.

This message was sent by Atlassian JIRA

Reply via email to