Naganarasimha G R commented on YARN-2934:

bq. Simple globs I was suggesting already cover even AppMaster.stderr.
Yep i agree i too mentioned the same in my earlier comment to ??emphasizing 
different cases here though it has stderr?? , what i was trying to point there 
was app developers can give a name of file in mixed cases (like 
*stdErr,*sysLog) and it cant be enforced by yarn. so it would be difficult for 
admin to determine and give for all kinds of app being run. 

bq. 99.9% of YARN users will never change this conf.
Definitely this feature is so rare that admin is going to configure repeatedly 
but my intention is to just make admin's work lil more easy. 

If you still weigh *code resuse* as more important than to make *admin config 
multiple patterns* of the log filename then i will update the patch 
accordingly,  waiting for your feedback.

bq. In ContainerLaunch#getErrorLogTail get rid of .. null check ...
Agree, will correct in next patch long with the test case failure

> Improve handling of container's stderr 
> ---------------------------------------
>                 Key: YARN-2934
>                 URL: https://issues.apache.org/jira/browse/YARN-2934
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Gera Shegalov
>            Assignee: Naganarasimha G R
>            Priority: Critical
>         Attachments: YARN-2934.v1.001.patch, YARN-2934.v1.002.patch, 
> YARN-2934.v1.003.patch, YARN-2934.v1.004.patch, YARN-2934.v1.005.patch, 
> YARN-2934.v1.006.patch, YARN-2934.v1.007.patch
> Most YARN applications redirect stderr to some file. That's why when 
> container launch fails with {{ExitCodeException}} the message is empty.

This message was sent by Atlassian JIRA

Reply via email to