MENG DING commented on YARN-4138:

Thanks [~sandflee] for the review.

bq. use Resources.fitsin(targetResource, lastConfirmedResource)?
Will do

bq. update lastConfirmedResource in RMContainer? and log debug to log info?
We should not update lastConfirmedResource in this scenario. This is the exact 
case we want to cover in this ticket, where the resource increase token may 
expire, and we need to roll back to the old resource. The only time we want to 
update lastConfirmedResource during resource increase is when 
Resources.equals(nmContainerResource, rmContainerResource).

bq. If am increase a containerA 1G -> 2G, and recieved a new container B, and 
have not told NM if am wants to decrease it to 500M, when using 
requestContainerResourceChange(Container container, Resource capability) , 
seems we should use container B?
Sorry I don't understand the question. Can you elaborate?


> Roll back container resource allocation after resource increase token expires
> -----------------------------------------------------------------------------
>                 Key: YARN-4138
>                 URL: https://issues.apache.org/jira/browse/YARN-4138
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, nodemanager, resourcemanager
>            Reporter: MENG DING
>            Assignee: MENG DING
>         Attachments: YARN-4138-YARN-1197.1.patch, YARN-4138-YARN-1197.2.patch
> In YARN-1651, after container resource increase token expires, the running 
> container is killed.
> This ticket will change the behavior such that when a container resource 
> increase token expires, the resource allocation of the container will be 
> reverted back to the value before the increase.

This message was sent by Atlassian JIRA

Reply via email to