sandflee commented on YARN-4138:

We should not update lastConfirmedResource in this scenario. This is the exact 
case we want to cover in this ticket, where the resource increase token may 
expire, and we need to roll back to the old resource. The only time we want to 
update lastConfirmedResource during resource increase is when 
Resources.equals(nmContainerResource, rmContainerResource).
1,  AM increase resource from 1G -> 2G, get container tokenA
2,  AM increase from 2G -> 4G,get container tokenB
3,  AM send tokenA to NM, and never send tokenB
4,  RM will decease resource to 1G and this is the expeceted?    seems we could 
set lastConfirmed resource to 2G

Sorry I don't understand the question. Can you elaborate?
when I using  requestContainerResourceChange(Container container, Resource 
capability), I have a question about which container we should pass to this 
1, AM request resource and get a container A
2, AM send increase request and get a container B
3, when AM wants to decrease resource, shoud we pass container A or B to 
requestContainerResourceChange?   seems we shoud pass container B, even if 
container B is not send to NM?

> Roll back container resource allocation after resource increase token expires
> -----------------------------------------------------------------------------
>                 Key: YARN-4138
>                 URL: https://issues.apache.org/jira/browse/YARN-4138
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, nodemanager, resourcemanager
>            Reporter: MENG DING
>            Assignee: MENG DING
>         Attachments: YARN-4138-YARN-1197.1.patch, YARN-4138-YARN-1197.2.patch
> In YARN-1651, after container resource increase token expires, the running 
> container is killed.
> This ticket will change the behavior such that when a container resource 
> increase token expires, the resource allocation of the container will be 
> reverted back to the value before the increase.

This message was sent by Atlassian JIRA

Reply via email to