Jian He commented on YARN-3480:

thanks for updating,
- regarding this logic, it is possible that a particular attempt is not 
persisted in the store because of some connection failures. so the 
{{app.nextAttemptId - app.firstAttemptIdInStateStore}} does not necessarily 
indicate the number of attempts.
while (app.nextAttemptId - app.firstAttemptIdInStateStore
app.maxAppAttempts) {
- LevelDBRMStateStore#removeApplicationAttemptInternal does not need to use 
batch operation, as it only has one operation
- Could you also add a test case in RMStateStoreTestBase#testRMAppStateStore 
that the loading part also works correctly? i.e. loading an app with partial 
attempts works correctly.

> Recovery may get very slow with lots of services with lots of app-attempts
> --------------------------------------------------------------------------
>                 Key: YARN-3480
>                 URL: https://issues.apache.org/jira/browse/YARN-3480
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.6.0
>            Reporter: Jun Gong
>            Assignee: Jun Gong
>         Attachments: YARN-3480.01.patch, YARN-3480.02.patch, 
> YARN-3480.03.patch, YARN-3480.04.patch, YARN-3480.05.patch, 
> YARN-3480.06.patch, YARN-3480.07.patch, YARN-3480.08.patch, 
> YARN-3480.09.patch, YARN-3480.10.patch
> When RM HA is enabled and running containers are kept across attempts, apps 
> are more likely to finish successfully with more retries(attempts), so it 
> will be better to set 'yarn.resourcemanager.am.max-attempts' larger. However 
> it will make RMStateStore(FileSystem/HDFS/ZK) store more attempts, and make 
> RM recover process much slower. It might be better to set max attempts to be 
> stored in RMStateStore.
> BTW: When 'attemptFailuresValidityInterval'(introduced in YARN-611) is set to 
> a small value, retried attempts might be very large. So we need to delete 
> some attempts stored in RMStateStore and RMStateStore.

This message was sent by Atlassian JIRA

Reply via email to