[ 
https://issues.apache.org/jira/browse/YARN-4100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065637#comment-15065637
 ] 

Dian Fu commented on YARN-4100:
-------------------------------

Hi [~Naganarasimha],
Very sorry for late response. It LGTM overall. Just a few small comments as 
follows:
{quote}
When "yarn.nodemanager.node-labels.provider" is configured with "config", 
"Script"
{quote}
{{S}} should be lower case for {{Script}}.
{quote}
When "yarn.nodemanager.node-labels.provider" is configured with "config" then
{quote}
A comma can be added before {{then}}
{quote}
which queries the Node labels.
{quote}
{{Node}} can be {{node}}. Actually {{node label}}, {{Node Label}}, {{Node 
label}}, {{node Label}} appears a lot of times in the doc, I think they should 
be consistent.
{quote}
In case of multiple lines have this pattern, then last one will be considered
{quote}
A period should be added at the end.
{quote}
Configured  class needs to extend
{quote}
Two white space between {{Configured}} and {{class}}




 

> Add Documentation for Distributed and Delegated-Centralized Node Labels 
> feature
> -------------------------------------------------------------------------------
>
>                 Key: YARN-4100
>                 URL: https://issues.apache.org/jira/browse/YARN-4100
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: NodeLabel.html, YARN-4100.v1.001.patch, 
> YARN-4100.v1.002.patch
>
>
> Add Documentation for Distributed Node Labels feature



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to