Varun Saxena commented on YARN-4224:

Updated a WIP patch.
Few points. Would like to get views on them so that we can reach agreement.
1. UID is filled in info even if fields do not indicate INFO has to be 
returned. Moreover, the key is fixed as "UID". Should we make it configurable 
or documenting it would be enough ? User should not send any info key as UID 
2. Same goes for UID delimiter ? Should it be configurable ?
3. We have 2 options. Either set UID in TimelineReaderManager or in the storage 
implementation . Advantage of former is that we are delinking  UID 
implementation from backend storage implementation. Disadvantage is that we 
need to iterate over all the entities again to set UID.
If we choose latter, it is the reverse. We can set UID while creating entities. 
But any new storage implementation needs to take care of filling UID then.
I have as of now implemented the second option. Not yet added that UID needs to 
be filled in javadoc.
4. Also UID is being returned as of now in both UID endpoint queries and non 
UID endpoint queries. Send UID only for former ?

> Change the ATSv2 reader side REST interface to conform to current REST APIs' 
> in YARN
> ------------------------------------------------------------------------------------
>                 Key: YARN-4224
>                 URL: https://issues.apache.org/jira/browse/YARN-4224
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4224-YARN-2928.01.patch, 
> YARN-4224-feature-YARN-2928.wip.02.patch

This message was sent by Atlassian JIRA

Reply via email to