[ 
https://issues.apache.org/jira/browse/YARN-4100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067070#comment-15067070
 ] 

Wangda Tan commented on YARN-4100:
----------------------------------

Thanks [~Naganarasimha] and reviews from [~dian.fu], some suggestions:

Some suggestions:
- {{configuring labels to nodes in Distributed/(Delegated-Centralized) 
NodeLabel setup}} should be a part of {{Setting up ResourceManager to enable 
Node Labels}}.
- If you agree with {{Add/modify node-to-labels mapping to YARN}} should not 
include all the options. You can include an example like configuring 
ConfigurationNodeLabelsProvider to show how to get node-to-labels mapping to 
YARN.
- {{configuring labels to ..}} -> {{Configuring...}}
- {{yarn.node-labels.configuration-type | Set configuration type for node 
labels. Administrators can specify *"centralized"*, *"delegated-centralized"* 
or *"distributed"*. Default value is *"centralized"* and 
*"delegated-centralized"* needs to be set to fetch the labels from a interface 
in RM.}}.
"Default value is *"centralized"* and *"delegated-centralized"* needs to be set 
to fetch.." This is a little confusing to me: default value should be 
"centralized" only, and explanation of "delegated-centralized" should in the 
{{Setting up ResourceManager to enable Node Labels}}.
- {{**Distributed :** Mapping can be done through NM exposed interface 
*"NodeLabelsProvider"*...}}: This is too implementation-detailed to me, do you 
think is it better to say "Mapping will be set by configured 
NodeLabelsProvider" in NM, and then describe two different kinds of Providers
- {{**Delegated-Centralized :** Mapping can be done through RM exposed 
interface *"RMNodeLabelsMappingProvider"*...}} like above, could we say: 
"Mapping will be set by configured NodeLabelsProvider" in RM.
- For above two, {{Mapping}} -> {{Node-to-labels mapping}}
- {{By default 2 implementations are supported:}} -> "We have two different 
providers in YARN: ..."

> Add Documentation for Distributed and Delegated-Centralized Node Labels 
> feature
> -------------------------------------------------------------------------------
>
>                 Key: YARN-4100
>                 URL: https://issues.apache.org/jira/browse/YARN-4100
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: NodeLabel.html, YARN-4100.v1.001.patch, 
> YARN-4100.v1.002.patch, YARN-4100.v1.003.patch
>
>
> Add Documentation for Distributed Node Labels feature



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to