Varun Vasudev updated YARN-4172:
    Attachment: YARN-4172-YARN-3926.002.patch

bq. 1) Who will update DRC.resourceNames, I found currently it hardcoded to 
memory and vcores.

This will be handled as part of later patches. For now, only memory and vcores 
are supported. Eventually, the list will be generated via a config.

bq. 2) DominantResourceCalculator#compare: Need handle the case when 
resourceName not existed at lhs or rhs?

This would throw an exception in getResourceInformation.

bq. Could use ResourceInformation.compareTo instead of 
ResourceInformation.compareValue since resourceName equals to each other? Is it 
still necessary to keep compareValue?

Good point. Fixed.

bq. 3) Suggest to use > = < to do compare since of switch (diff).


bq. 4) DRC#computeAvailableContainers need consider denominator == 0?

The current implementation doesn't handle the case - how should I handle it?

bq. 5) Is it possible we can return a dummy ResourceInformation (with value == 
0) instead of check exception at lots of places.

I would prefer to throw an exception - FairScheduler uses 0 Resource objects in 
a lot of place - I don't want to return something that indicates the operation 
was successful.

> Extend DominantResourceCalculator to account for all resources
> --------------------------------------------------------------
>                 Key: YARN-4172
>                 URL: https://issues.apache.org/jira/browse/YARN-4172
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: YARN-4172-YARN-3926.001.patch, 
> YARN-4172-YARN-3926.002.patch
> Now that support for multiple resources is present in the resource class, we 
> need to modify DominantResourceCalculator to account for the new resources.

This message was sent by Atlassian JIRA

Reply via email to