Varun Saxena commented on YARN-4224:

Another option would be to make entities endpoint as 
{{/ws/v2/timeline/apps/\{app UID\}/entities?entityType=...}}. However this will 
be a mandatory param(there will be check at server side).
Pls note that hierarchical REST endpoint has been kept as 
{{/ws/v2/timeline/apps/\{appid\}/entities/\{entitytype\}}}. Pls note app UID 
and app id are not the same thing. We need some differentiation between UID 
endpoint and hierarchical endpoint because if we follow general scheme the 
endpoints will clash.
Although mandatory params in REST are part of path param generally but I guess 
we have no other option here. For UID,  we can put entity type as query param 
and hierarchical endpoint a path param. 
Its confusing anyways.

Or should we have endpoints like  {{/ws/v2/timeline/runsUID/\{run UID\}/apps}}, 
 {{/ws/v2/timeline/appsUID/\{app UID\}}}, {{/ws/v2/timeline/appsUID/\{app 
UID\}/entities/\{entitytype\}}}, thereby clearly indicating that UID is being 
passed and avoiding conflict as mentioned above.
Thoughts ?

> Change the ATSv2 reader side REST interface to conform to current REST APIs' 
> in YARN
> ------------------------------------------------------------------------------------
>                 Key: YARN-4224
>                 URL: https://issues.apache.org/jira/browse/YARN-4224
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4224-YARN-2928.01.patch, 
> YARN-4224-feature-YARN-2928.wip.02.patch

This message was sent by Atlassian JIRA

Reply via email to