Naganarasimha G R commented on YARN-4479:

Hi [~rohithsharma],  Thanks for the patch,
New approach seems to be better than the older as it tries to avoid additional 
data structure used for the same purpose, but few points :
* If we consider for FairOrderingPolicy it first considers {{FairComparator}} 
and then the {{FifoComparator}}, so only if fairness is equal it will consider 
whether the application was already running, so would it be better to add 
additional comparator for recovery which can be used by both Fair and Fifo ?
* So it will be totally left to Ordering policy whether to consider the order 
of the recovered app based on submission time or not, so better to get that 
documented so that custom ordering policy can consider it.

> Retrospect app-priority in pendingOrderingPolicy during recovering 
> applications
> -------------------------------------------------------------------------------
>                 Key: YARN-4479
>                 URL: https://issues.apache.org/jira/browse/YARN-4479
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, resourcemanager
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: 0001-YARN-4479.patch, 0002-YARN-4479.patch
> Currently, same ordering policy is used for pending applications and active 
> applications. When priority is configured for an applications, during 
> recovery high priority application get activated first. It is possible that 
> low priority job was submitted and running state. 
> This causes low priority job in starvation after recovery

This message was sent by Atlassian JIRA

Reply via email to