[ 
https://issues.apache.org/jira/browse/YARN-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072057#comment-15072057
 ] 

Wangda Tan commented on YARN-4224:
----------------------------------

Hi [~varun_saxena]/[~sjlee0],

Apologize for my very late response, I'm traveling recently.

My thoughts:
1) For semantics vs. implementation
I agree we need to consider implementation. For now, for the flat (what I 
proposed) API, I think we don't need to support more semantics than what Varun 
has proposed for hierarchy APIs: 
https://issues.apache.org/jira/browse/YARN-4224?focusedCommentId=15070133&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15070133.
 Which should not bring any new issues to backend implementation.

I think it's better to make user API extensible, since we could continuously 
improve backend implementation, we don't have to break API in the future.

2) For entity-type in query parameter.
As I mentioned above, I'm fine to only support entity-type specified queries, 
queries without entity-type specified will receive error response. We can relax 
this limitation once our backend supports it and real requirement arrives.

3) For support flat API and hiearchy API together
I'm fine with support them together if both of them are required. Since web UI 
needs flat API, are you OK with supporting flat API first?

4)
bq. At any rate, I agree that due to the possibility of omission ambiguities 
are perhaps possible. In that case, I suspect using different query nouns might 
be the ultimate solution (e.g. "apps" for the hierachical and "apps-uid" for 
UIDs).
Since we're using UIDs for these objects, I feel that adding "-uid" to API is 
not necessary to me and could potentially confusing people.

Thoughts?

> Change the ATSv2 reader side REST interface to conform to current REST APIs' 
> in YARN
> ------------------------------------------------------------------------------------
>
>                 Key: YARN-4224
>                 URL: https://issues.apache.org/jira/browse/YARN-4224
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4224-YARN-2928.01.patch, 
> YARN-4224-feature-YARN-2928.wip.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to