[
https://issues.apache.org/jira/browse/YARN-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072295#comment-15072295
]
Wangda Tan commented on YARN-4335:
----------------------------------
Thanks [~kkaranasos],
The patch generally looks good to me, some nits:
- Javadocs of getExecutionType is wrong.
- I would prefer to keep new APIs to be unstable so we could update them before
features become stable
- Javadocs of ExecutionType: if we use ExecutionType for resource request, I
would suggest to add description that scheduler could use it to decide if idle
resources could be used by the resource request.
> Allow ResourceRequests to specify ExecutionType of a request ask
> ----------------------------------------------------------------
>
> Key: YARN-4335
> URL: https://issues.apache.org/jira/browse/YARN-4335
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Konstantinos Karanasos
> Assignee: Konstantinos Karanasos
> Attachments: YARN-4335-yarn-2877.001.patch
>
>
> YARN-2882 introduced container types that are internal (not user-facing) and
> are used by the ContainerManager during execution at the NM.
> With this JIRA we are introducing (user-facing) resource request types that
> are used by the AM to specify the type of the ResourceRequest.
> We will initially support two resource request types: CONSERVATIVE and
> OPTIMISTIC.
> CONSERVATIVE resource requests will be handed internally to containers of
> GUARANTEED type, whereas OPTIMISTIC resource requests will be handed to
> QUEUEABLE containers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
