[ 
https://issues.apache.org/jira/browse/YARN-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081550#comment-15081550
 ] 

MENG DING commented on YARN-4528:
---------------------------------

Hi, [~sandflee]

With current logic, I think RM won't know if a container decrease msg has 
really been persisted in NM state store or not, even if you decrease resource 
synchronously in NM. For example, suppose we now synchronously decrease 
resource in NM, and something goes wrong when writing the NM state store, then 
an exception will be thrown, and will be caught by the following statement 
during status update in NM:

{code}
catch (Throwable e) {

            // TODO Better error handling. Thread can die with the rest of the
            // NM still running.
            LOG.error("Caught exception in status-updater", e);
          } 
{code}

So to me, there is really no benefit of decreasing container resource 
synchronously in NM, is it?

> decreaseContainer Message maybe lost if NM restart
> --------------------------------------------------
>
>                 Key: YARN-4528
>                 URL: https://issues.apache.org/jira/browse/YARN-4528
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: sandflee
>         Attachments: YARN-4528.01.patch
>
>
> we may pending the container decrease msg util next heartbeat. or checks the 
> resource with rmContainer when node register.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to