[
https://issues.apache.org/jira/browse/YARN-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082332#comment-15082332
]
Advertising
Naganarasimha G R commented on YARN-4537:
-----------------------------------------
Hi [~rohithsharma],
+1 for the approach,
Few nits in the patch :
* formatting has happened for the lines which are not modified also ?
* instead of {{!(p2 == null)}} we can use *p2 != null* ?
> Pull out priority comparison from fifocomparator and use compound comparator
> for FifoOrdering policy
> ----------------------------------------------------------------------------------------------------
>
> Key: YARN-4537
> URL: https://issues.apache.org/jira/browse/YARN-4537
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Attachments: 0001-YARN-4537.patch, 0002-YARN-4537.patch
>
>
> Currently, priority comparison is integrated with FifoComparator. There
> should be a separate comparator defined for priority comparison so that down
> the line if any new ordering policy wants to integrate priority, they can use
> compound comparator where priority will be high preference.
> The following changes are expected to be done as part of this JIRA
> # Pull out priority comparison from FifoComparator
> # Define new priority comparator
> # Use compound comparator for FifoOrderingPolicy. Oder of preference is
> Priority,FIFO
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)