Sunil G commented on YARN-4029:

Looks fine. 

Some minor nits:
+  public LogAggregationStatus getLogAggregationStatus() {
+    ApplicationStateDataProtoOrBuilder p = viaProto ? proto : builder;
+    return ProtoUtils.convertFromProtoFormat(p.getLogAggregationStatus());
+  }

May be if {{p.getLogAggregationStatus()}} is null, you can directly return null 
from this getter.

Since you are planning to set {{LogAggregationStatus.NOT_START}} as default for 
all AppStates, I suggest you can try setting 
{{appState.setLogAggregationStatus(logstatus);}} in the primary {{newInstance}} 
and pass this default from other cases. Else if some new paramters comes later, 
it may become more confusing.

> Update LogAggregationStatus to store on finish
> ----------------------------------------------
>                 Key: YARN-4029
>                 URL: https://issues.apache.org/jira/browse/YARN-4029
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>         Attachments: 0001-YARN-4029.patch, 0002-YARN-4029.patch, 
> 0003-YARN-4029.patch, 0004-YARN-4029.patch, Image.jpg
> Currently the log aggregation status is not getting updated to Store. When RM 
> is restarted will show NOT_START. 
> Steps to reproduce
> ================
> 1.Submit mapreduce application
> 2.Wait for completion
> 3.Once application is completed switch RM
> *Log Aggregation Status* are changing
> *Log Aggregation Status* from SUCCESS to NOT_START

This message was sent by Atlassian JIRA

Reply via email to