[
https://issues.apache.org/jira/browse/YARN-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087186#comment-15087186
]
Akira AJISAKA commented on YARN-4544:
-------------------------------------
Thanks [~bwtakacy] for reporting this and creating the patch. It looks good to
me.
I found a typo near the change. Would you fix it?
{code}
LOG.info("rollingMonitorInterval is set as "
+ configuredRollingMonitorInterval + ". "
+ "The log rolling mornitoring interval is disabled. "
+ "The logs will be aggregated after this application is
finished.");
{code}
mornitoring should be monitoring.
> All the log messages about rolling monitoring interval are shown with the
> WARN level
> ------------------------------------------------------------------------------------
>
> Key: YARN-4544
> URL: https://issues.apache.org/jira/browse/YARN-4544
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: log-aggregation, nodemanager
> Affects Versions: 2.7.1
> Reporter: Takashi Ohnishi
> Attachments: YARN-4544.patch
>
>
> About yarn.nodemanager.log-aggregation.roll-monitoring-interval-seconds,
> there are three log messages corresponding to the value set to this
> parameter, but all of them are shown with the WARN level.
> (a) disabled (default)
> {code}
> 2016-01-05 22:19:29,062 WARN
> org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggreg
> ation.AppLogAggregatorImpl: rollingMonitorInterval is set as -1. The log
> rolling mornitoring interval is disabled. The logs will be aggregated after
> this application is finished.
> {code}
> (b) enabled
> {code}
> 2016-01-06 00:41:15,808 WARN
> org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.AppLogAggregatorImpl:
> rollingMonitorInterval is set as 7200. The logs will be aggregated every
> 7200 seconds
> {code}
> (c) enabled but wrong configuration
> {code}
> 2016-01-06 00:39:50,820 WARN
> org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.AppLogAggregatorImpl:
> rollingMonitorIntervall should be more than or equal to 3600 seconds. Using
> 3600 seconds instead.
> {code}
> I think it is better to output with WARN only in case (c), but it is ok to
> output with INFO in case (a) and (b).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
