[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090213#comment-15090213
]
Sangjin Lee commented on YARN-3995:
-----------------------------------
It looks pretty good. Thanks for updating the patch [~Naganarasimha].
One last minor point is the shutdown() call in serviceStop(). It might be a
good idea to wait a little bit to ensure the executor service is shut down.
It's virtually certain all outstanding tasks will finish within the linger
period, so something like the following is slightly more helpful:
{code}
scheduler.shutdown();
if (!scheduler.awaitTermination(collectorLingerPeriod, TimeUnit.MILLISECONDS)) {
LOG.warn(...);
}
...
{code}
Also, are some of the checkstyle warnings fixable?
> Some of the NM events are not getting published due race condition when AM
> container finishes in NM
> ----------------------------------------------------------------------------------------------------
>
> Key: YARN-3995
> URL: https://issues.apache.org/jira/browse/YARN-3995
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, timelineserver
> Affects Versions: YARN-2928
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Labels: yarn-2928-1st-milestone
> Attachments: YARN-3995-feature-YARN-2928.v1.001.patch,
> YARN-3995-feature-YARN-2928.v1.002.patch
>
>
> As discussed in YARN-3045: While testing in TestDistributedShell found out
> that few of the container metrics events were failing as there will be race
> condition. When the AM container finishes and removes the collector for the
> app, still there is possibility that all the events published for the app by
> the current NM and other NM are still in pipeline,
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
