[
https://issues.apache.org/jira/browse/YARN-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090344#comment-15090344
]
Naganarasimha G R commented on YARN-4565:
-----------------------------------------
Hi [~wangda],
Overall the approach seems to be good, but few queries
* earlier synchronization was only for modifying {{entitiesToReorder}} but
{{removeSchedulableEntity}} is made synchronized instead of only covering
{{entitiesToReorder.remove(s.getId());}} would it be better to have
{{synchronized(this)}} block here ?
* though the current approach is fine Any particular reason not to use
{{application.isWaitingForAMContainer()}} than modifying
{{AbstractComparatorOrderingPolicy}}, as its much simple?
> When sizeBasedWeight enabled for FairOrderingPolicy in CapacityScheduler,
> Sometimes lead to situation where all queue resources consumed by AMs only
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-4565
> URL: https://issues.apache.org/jira/browse/YARN-4565
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler, capacityscheduler
> Affects Versions: 2.8.0
> Reporter: Karam Singh
> Assignee: Wangda Tan
> Attachments: YARN-4565.1.patch
>
>
> When sizeBasedWeight enabled for FairOrderingPolicy in CapacityScheduler,
> Sometimes lead to situation where all queue resources consumed by AMs only,
> So from users perpective it appears that all application in queue are stuck,
> whole queue capacity is comsumed by AMs
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
