[
https://issues.apache.org/jira/browse/YARN-4492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094506#comment-15094506
]
Eric Payne commented on YARN-4492:
----------------------------------
Thanks for updating the patch so quickly, [~Naganarasimha]. I think it looks
good overall. I have a couple of minor grammatical nits:
bq. The CapacityScheduler supports preemption of container(s) from the queues
whose resource usage is more than their guaranteed capacity. Following
configuration parameters needs to be enabled in yarn-site.xml, for supporting
preemption of application containers.
- I would say {{container}} rather than {{container(s)}}
- {{_The_ following configuration parameters _need_ to ...}}
- Take out comma after {{yarn-site.xml}}
bq. yarn.resourcemanager.scheduler.monitor.policies
- {{Configured policies _need_ to be ...}}
bq. Following configuration parameters can be configured in yarn-site.xml, to
control the preemption of containers when ProportionalCapacityPreemptionPolicy
class is configured for yarn.resourcemanager.scheduler.monitor.policies
- I would remove the comma after {{yarn-site.xml}}
Other than that, it looks good.
> Add documentation for preemption supported in Capacity scheduler
> ----------------------------------------------------------------
>
> Key: YARN-4492
> URL: https://issues.apache.org/jira/browse/YARN-4492
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Priority: Minor
> Attachments: CapacityScheduler.html, YARN-4492.v1.001.patch,
> YARN-4492.v1.002.patch, YARN-4492.v1.003.patch, YARN-4492.v2.001.patch
>
>
> As part of YARN-2056, Support has been added to disable preemption for a
> specific queue. This is a useful feature in a multiload cluster but currently
> missing documentation.
> Complete preemption is not documented hence update all configurations for
> capacity scheduler preemption
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
