[
https://issues.apache.org/jira/browse/YARN-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095598#comment-15095598
]
Xuan Gong commented on YARN-4559:
---------------------------------
Thanks, Jian for working on this, and Thanks, Karithik for the review.
The patch looks good overall. I do not have any other comments other than
Karithik's previous comment.
But I have one general concern for this:
1. Can we move ResourceManager#createAndStartCurator() from ResourceManager
into LeaderElectorService ? Otherwise, it looks like we only support ZK as
leaderElector Service. Currently, it is true. But I still think that we can add
one more level abstraction for the LeaderElector Service, and let current
LeaderElectorService extends/inherent from it ? Basically, move all the curator
related code from ResourceManager.java to LeaderElectorService.java.
> Make leader elector and zk store share the same curator client
> --------------------------------------------------------------
>
> Key: YARN-4559
> URL: https://issues.apache.org/jira/browse/YARN-4559
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Jian He
> Assignee: Jian He
> Attachments: YARN-4559.1.patch
>
>
> After YARN-4438, we can reuse the same curator client for leader elector and
> zk store
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
