[ 
https://issues.apache.org/jira/browse/YARN-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097701#comment-15097701
 ] 

Wangda Tan commented on YARN-4538:
----------------------------------

Thanks for updating, [~bibinchundatt],

Patch generally looks good, one minor comment is:
{code}
  public void allocateResources(String user, Resource res,
      boolean decrPending)
{code}
The 3rd boolean parameter is not needed. Nobody is using it now. 

> QueueMetrics pending  cores and memory metrics wrong
> ----------------------------------------------------
>
>                 Key: YARN-4538
>                 URL: https://issues.apache.org/jira/browse/YARN-4538
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>         Attachments: 0001-YARN-4538.patch, 0002-YARN-4538.patch, 
> 0003-YARN-4538.patch
>
>
> Submit 2 application to default queue 
> Check queue metrics for pending cores and memory
> {noformat}
>     List<QueueInfo> allQueues = client.getChildQueueInfos("root");
>     for (QueueInfo queueInfo : allQueues) {
>       QueueStatistics quastats = queueInfo.getQueueStatistics();
>       System.out.println(quastats.getPendingVCores());
>       System.out.println(quastats.getPendingMemoryMB());
>     }
> {noformat}
> *Output :*
> -20
> -20480



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to