[
https://issues.apache.org/jira/browse/YARN-4557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106186#comment-15106186
]
Wangda Tan commented on YARN-4557:
----------------------------------
Looks good, +1. Thanks [~Naganarasimha],
One nit is:
{code}
1671 // Test case 1
1672 // Both a/b has used_capacity(x) = 0, when doing exclusive
allocation, b
1673 // will go first since b has more capacity(x)
{code}
It should be "a should go first" according to your test case.
> Improper Queues sorting in PartitionedQueueComparator when accessible node
> labels is configured as ANY
> ------------------------------------------------------------------------------------------------------
>
> Key: YARN-4557
> URL: https://issues.apache.org/jira/browse/YARN-4557
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Priority: Minor
> Attachments: YARN-4557.v1.001.patch, YARN-4557.v2.001.patch,
> YARN-4557.v2.002.patch, YARN-4557.v3.001.patch
>
>
> * When queue has * as accessibility, then the queue ordering was not
> happening properly.
> Few Small nits
> * In AppSchedulingInfo comparator field doesn't have generics
> * TestNodeLabelContainerAllocation.testResourceRequestUpdateNodePartitions
> has unused variable
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
