[
https://issues.apache.org/jira/browse/YARN-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107220#comment-15107220
]
Arun Suresh commented on YARN-4360:
-----------------------------------
Thanks for the patch [~curino], couple of minor comments from my first pass:
In GreedyReservationAgent,
# Change the GREEDY_ALLOCATION_DIRECTION to be boolean instead of string (I am
assuming it will always be either left or right).
# Use yarnConfiguration.getBoolean() and pass in a default value.. instead of
using if.. then.. else
In IterativePlanner
# Line 174..200, an if block (the {{if(jobtype ==
ReservationRequestInterpreter.R_ORDER_NO_GAP && ..)}}) exists in both the
if(allocateLeft).. else{} branches. You can probably pull that up.
# I also noticed that you replace all the "return nulls” with throwing a
PlanningException, is that ok ?
Ill provide more comments on the {{StageAllocatorGreedyRLE}} after I go thru it
in a bit more detail...
> Improve GreedyReservationAgent to support "early" allocations, and
> performance improvements
> --------------------------------------------------------------------------------------------
>
> Key: YARN-4360
> URL: https://issues.apache.org/jira/browse/YARN-4360
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler, fairscheduler, resourcemanager
> Affects Versions: 2.8.0
> Reporter: Carlo Curino
> Assignee: Carlo Curino
> Attachments: YARN-4360.2.patch, YARN-4360.3.patch, YARN-4360.5.patch,
> YARN-4360.patch
>
>
> The GreedyReservationAgent allocates "as late as possible". Per various
> conversations, it seems useful to have a mirror behavior that allocates as
> early as possible. Also in the process we leverage improvements from
> YARN-4358, and implement an RLE-aware StageAllocatorGreedy(RLE), which
> significantly speeds up allocation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
