[ 
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109286#comment-15109286
 ] 

Arun Suresh commented on YARN-4496:
-----------------------------------

Agreed.. Couple of minor comments:

# I noticed that you had changed the {{RMProxy.createRetryPolicy}} method to 
allow setting a boolean flag for HA. Do we need that change ? since I see that 
you are calling {{HAUtils.isHAEnabled()}} whenever you are calling 
{{createRetryPolicy}} anyway.
# Can we kill the RM threads before exiting the test case ?

minor nit :
# the test case looks good, but am worried it might be a bit flaky due to 
reliance on the clock and timing.. anyway it can be refactored ?


> Improve HA ResourceManager Failover detection on the client
> -----------------------------------------------------------
>
>                 Key: YARN-4496
>                 URL: https://issues.apache.org/jira/browse/YARN-4496
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: client, resourcemanager
>            Reporter: Arun Suresh
>            Assignee: Jian He
>         Attachments: YARN-4496.1.patch, YARN-4496.2.patch
>
>
> HDFS deployments can currently use the {{RequestHedgingProxyProvider}} to 
> improve Namenode failover detection in the client. It does this by 
> concurrently trying all namenodes and picks the namenode that returns the 
> fastest with a successful response as the active node.
> It would be useful to have a similar ProxyProvider for the Yarn RM (it can 
> possibly be done by converging some the class hierarchies to use the same 
> ProxyProvider)
> This would especially be useful for large YARN deployments with multiple 
> standby RMs where clients will be able to pick the active RM without having 
> to traverse a list of configured RMs. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to