[
https://issues.apache.org/jira/browse/YARN-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112798#comment-15112798
]
Junping Du commented on YARN-4219:
----------------------------------
Thanks [~gtCarrera9] for updating the patch and [~xgong] for review.
I briefly go through the patch, it looks fine in overall but could be some
trivial issues.
A quick question for MapTimelineStore, what's this method doing which is a bit
confusing?
{noformat}
+ private static Object maybeConvert(Object o) {
+ if (o instanceof Long) {
+ Long l = (Long)o;
+ if (l >= Integer.MIN_VALUE && l <= Integer.MAX_VALUE) {
+ return l.intValue();
+ }
+ }
+ return o;
+ }
{noformat}
> New levelDB cache storage for timeline v1.5
> -------------------------------------------
>
> Key: YARN-4219
> URL: https://issues.apache.org/jira/browse/YARN-4219
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.8.0
> Reporter: Li Lu
> Assignee: Li Lu
> Attachments: YARN-4219-YARN-4265.001.patch,
> YARN-4219-YARN-4265.002.patch, YARN-4219-YARN-4265.003.patch,
> YARN-4219-trunk.001.patch, YARN-4219-trunk.002.patch,
> YARN-4219-trunk.003.patch, YARN-4219-trunk.004.patch,
> YARN-4219-trunk.005.patch
>
>
> We need to have an "offline" caching storage for timeline server v1.5 after
> the changes in YARN-3942. The in memory timeline storage may run into OOM
> issues when used as a cache storage for entity file timeline storage. We can
> refactor the code and have a level db based caching storage for this use
> case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
