[ 
https://issues.apache.org/jira/browse/YARN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113484#comment-15113484
 ] 

Sangjin Lee commented on YARN-4062:
-----------------------------------

Regarding getting access to YarnConfiguration, generically speaking there 
should be a way for a co-processor to get a hold of HBaseConfiguration or 
YarnConfiguration? I'm not too familiar with the HBase code, but I presume 
there are ways...

I went over the latest patch, and it looks pretty good other than the 
outstanding issue of the configuration and javadoc/whitespace/... violations. A 
couple of additional minor issues:
- in TestHBaseStorageFlowRunCompaction.java, {{Connection conn}} in line 139 
appears unused
- also in that file, {{ScanType scanType}} in line 199 is unused

> Add the flush and compaction functionality via coprocessors and scanners for 
> flow run table
> -------------------------------------------------------------------------------------------
>
>                 Key: YARN-4062
>                 URL: https://issues.apache.org/jira/browse/YARN-4062
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Vrushali C
>            Assignee: Vrushali C
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4062-YARN-2928.1.patch, 
> YARN-4062-feature-YARN-2928.01.patch, YARN-4062-feature-YARN-2928.02.patch
>
>
> As part of YARN-3901, coprocessor and scanner is being added for storing into 
> the flow_run table. It also needs a flush & compaction processing in the 
> coprocessor and perhaps a new scanner to deal with the data during flushing 
> and compaction stages. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to