[ 
https://issues.apache.org/jira/browse/YARN-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114416#comment-15114416
 ] 

Rohith Sharma K S commented on YARN-4573:
-----------------------------------------

typos fix can be done in this patch itself, but I see few places changes would 
not be required at all, for example
{code}
     RMAppEvent event =                 
673               new RMAppFailedAttemptEvent(application.getApplicationId(), 
{code}
May be you can check your eclipse formatter!!

> TestRMAppTransitions.testAppRunningKill and testAppKilledKilled fail on trunk
> -----------------------------------------------------------------------------
>
>                 Key: YARN-4573
>                 URL: https://issues.apache.org/jira/browse/YARN-4573
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager, test
>            Reporter: Takashi Ohnishi
>            Assignee: Takashi Ohnishi
>         Attachments: YARN-4573.1.patch
>
>
> These tests often fails with 
> {code}
> testAppRunningKill[0](org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions)
>   Time elapsed: 0.042 sec  <<< FAILURE!
> java.lang.AssertionError: application finish time is not greater then 0
>       at org.junit.Assert.fail(Assert.java:88)
>       at org.junit.Assert.assertTrue(Assert.java:41)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions.assertTimesAtFinish(TestRMAppTransitions.java:321)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions.assertKilled(TestRMAppTransitions.java:338)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions.testAppRunningKill(TestRMAppTransitions.java:760)
> testAppKilledKilled[0](org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions)
>   Time elapsed: 0.04 sec  <<< FAILURE!
> java.lang.AssertionError: application finish time is not greater then 0
>       at org.junit.Assert.fail(Assert.java:88)
>       at org.junit.Assert.assertTrue(Assert.java:41)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions.assertTimesAtFinish(TestRMAppTransitions.java:321)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions.testAppKilledKilled(TestRMAppTransitions.java:925)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to