[ 
https://issues.apache.org/jira/browse/YARN-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115210#comment-15115210
 ] 

Varun Vasudev commented on YARN-4307:
-------------------------------------

My apologies for the delay Naga. Patch looks mostly good to me. Some more minor 
nits -

1) rename getApplicationBlackListNodes to getBlackListedNodes

2) In RMAppAttemptBlock.java
{code}
+    String appBlacklistedNodes =
+        getNodeString(rmAppAttempt.getApplicationBlackListNodes());
+    String rmBlackListedNodes = getNodeString(
+        rmAppAttempt.getAMBlacklist().getBlacklistUpdates().getAdditions());
{code}
Add a comment explaining difference between the two.

3) In RMAppAttemptBlock.java
{code}
._("RM Blacklisted Nodes:", rmBlackListedNodes);
{code}
Change "RM Blacklisted Nodes" to "RM Blacklisted Nodes(for AM launches)"

4) In RMAppBlock.java
{code}
String appBlacklistedNodesCount = String.valueOf(nodes.size());
String rmBlacklistedNodesCount = String.valueOf(rmAppAttempt
    .getAMBlacklist().getBlacklistUpdates().getAdditions().size());
{code}
Similar to (2) - add a comment explaining difference

5) In AppAttemptInfo
rename blacklistedNodesForAMByRM to rmBlacklistedNodesForAMLaunches

> Blacklisted nodes for AM container is not getting displayed in the Web UI
> -------------------------------------------------------------------------
>
>                 Key: YARN-4307
>                 URL: https://issues.apache.org/jira/browse/YARN-4307
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager, webapp
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: AppInfoPage.png, RMappAttempt.png, 
> YARN-4307.v1.001.patch, YARN-4307.v1.002.patch, YARN-4307.v1.003.patch, 
> webpage.png, yarn-capacity-scheduler-debug.log
>
>
> In pseudo cluster had 2 NM's  and had launched app with incorrect 
> configuration *./hadoop org.apache.hadoop.mapreduce.SleepJob 
> -Dmapreduce.job.node-label-expression=labelX  
> -Dyarn.app.mapreduce.am.env=JAVA_HOME=/no/jvm/here  -m 5 -mt 1200*.
> First attempt failed and 2nd attempt was launched, but the application was 
> hung. In the scheduler logs found that localhost was blacklisted but in the 
> UI (app& apps listing page) count was shown as zero and as well no hosts 
> listed in the app page. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to