[
https://issues.apache.org/jira/browse/YARN-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118254#comment-15118254
]
Sangjin Lee commented on YARN-4224:
-----------------------------------
{quote}
I have used Long for a reason here. I plan to use the class
TimelineReaderContext while fixing YARN-4446(which is regarding refactoring
code to reduce number of params in reader API). In reader API, flow run id
being null indicates that it has not come from the client. Probably we can use
a sentinel value like -1 and use primitive long as well(assuming run id wont be
negative most probably) but current reader code assumes null indicating flow
run has not been supplied by client.
Thoughts ?
{quote}
That's fine then. That thought occurred to me, but it wasn't clear whether you
were distinguishing the case of a missing value.
{quote}
Agree mostly. But shouldn't we make TimelineReaderUtils public(after moving web
services related methods as per Li's comments to a new class). Cant say where
but split and joinAndEscapeStrings methods might be useful elsewhere in future.
Look somewhat generic. Thoughts ?
{quote}
If the class is to be used outside the package by other classes, then it needs
to be public. I was making a general comment arguing for reducing the public
surface to the extent possible.
> Support fetching entities by UID and change the REST interface to conform to
> current REST APIs' in YARN
> -------------------------------------------------------------------------------------------------------
>
> Key: YARN-4224
> URL: https://issues.apache.org/jira/browse/YARN-4224
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Labels: yarn-2928-1st-milestone
> Attachments: YARN-4224-YARN-2928.01.patch,
> YARN-4224-YARN-2928.05.patch, YARN-4224-feature-YARN-2928.04.patch,
> YARN-4224-feature-YARN-2928.wip.02.patch,
> YARN-4224-feature-YARN-2928.wip.03.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
