[
https://issues.apache.org/jira/browse/YARN-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119015#comment-15119015
]
Varun Saxena commented on YARN-4644:
------------------------------------
Updated patch to fix findbugs warning as part of this JIRA itself. Closing
YARN-4645 as duplicate.
> TestRMRestart fails on YARN-2928 branch
> ---------------------------------------
>
> Key: YARN-4644
> URL: https://issues.apache.org/jira/browse/YARN-4644
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Attachments: YARN-4644-YARN-2928.01.patch,
> YARN-4644-YARN-2928.02.patch
>
>
> This was reported by YARN-4238 QA report. Refer to
> https://builds.apache.org/job/PreCommit-YARN-Build/10389/testReport/
> Error reported is as under :
> {noformat}
> org.mockito.exceptions.verification.TooManyActualInvocations:
> noOpSystemMetricPublisher.appCreated(
> <any>,
> <any>
> );
> Wanted 3 times:
> -> at
> org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testRMRestartGetApplicationList(TestRMRestart.java:955)
> But was 6 times. Undesired invocation:
> -> at
> org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.recover(ResourceManager.java:1274)
> at
> org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testRMRestartGetApplicationList(TestRMRestart.java:955)
> {noformat}
> Failing because in {{RMAppImpl#recover}}, {{sendATSCreateEvent}} has been
> called twice.
> Has been introduced during rebase I guess.
> After removing the duplicate call, the test passes.
> There is a *findbugs warning* in resourcemanager in YARN-2928 branch as well.
> Fix it as part of this JIRA itself.
> {noformat}
> DLS Dead store to keepAliveApps in
> org.apache.hadoop.yarn.server.resourcemanager.ResourceTrackerService.nodeHeartbeat(NodeHeartbeatRequest)
> Bug type DLS_DEAD_LOCAL_STORE (click for details)
> In class org.apache.hadoop.yarn.server.resourcemanager.ResourceTrackerService
> In method
> org.apache.hadoop.yarn.server.resourcemanager.ResourceTrackerService.nodeHeartbeat(NodeHeartbeatRequest)
> Local variable named keepAliveApps
> At ResourceTrackerService.java:[line 486]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
