[ 
https://issues.apache.org/jira/browse/YARN-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120058#comment-15120058
 ] 

Karthik Kambatla commented on YARN-4462:
----------------------------------------

bq.  I don't think it is a reasonable scenario to set this default value to 
non-preemptable.
Fair point. I agree it makes more sense to not allow setting a default value of 
non-preemptable. 

The patch itself looks good to me, but for the test being added to 
TestFairScheduler instead of TestFairSchedulerPreemption. Filed YARN-4648 to 
track that. 

+1 on this patch. Checking it in. 

> FairScheduler: Disallow preemption from a queue
> -----------------------------------------------
>
>                 Key: YARN-4462
>                 URL: https://issues.apache.org/jira/browse/YARN-4462
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: fairscheduler
>    Affects Versions: 2.6.0
>            Reporter: Tao Jie
>            Assignee: Tao Jie
>         Attachments: YARN-4462.001.patch, YARN-4462.002.patch, 
> YARN-4462.003.patch, YARN-4462.004.patch
>
>
> When scheduler preemption is enabled, applications could be preempted if they 
> obtain resource over they should take. 
> When a mapreduce application is preempted some resource, it just runs slower. 
> However, when the preempted application is a long-run service, such as tomcat 
> running in slider, the service would fail.
> So we should have a flag for application to indicate the scheduler that those 
> application should not be preempted. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to