[
https://issues.apache.org/jira/browse/YARN-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123332#comment-15123332
]
Varun Vasudev commented on YARN-4649:
-------------------------------------
Thanks for the patch [~sidharta-s]. Some feedack -
1) Instead of
{code}
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Recovering container with state: ");
+ LOG.debug("Diagnostics: " + rcs.getDiagnostics());
+ LOG.debug("Exit Code: " + rcs.getExitCode());
+ LOG.debug("Start Request: " + rcs.getStartRequest());
+ LOG.debug("Status: " + rcs.getStatus());
+ }
{code}
can you add a toString() method to RecoveredContainerState and use that when
logging? That way if someone adds a new field, it'll get reflected in the logs
automatically
2) For the following statements, can you merge them to one log line?
{code}
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("storeContainer.containerId: " + containerId );
+ LOG.debug("storeContainer.startRequest: " + startRequest);
+ }
{code}
and
{code}
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("storeContainerDiagnostics.containerId: " + containerId);
+ LOG.debug("storeContainerDiagnostics.diagnostics: " + diagnostics);
+ }
{code}
and
{code}
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("storeContainerResourceChanged.containerId: " + containerId);
+ LOG.debug("storeContainerResourceChanged.capability: " + capability);
+ }
{code}
and
{code}
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("storeApplication.appId: " + appId);
+ LOG.debug("storeApplication.proto: " + p);
+ }
{code}
> Add additional logging to some NM state store operations
> --------------------------------------------------------
>
> Key: YARN-4649
> URL: https://issues.apache.org/jira/browse/YARN-4649
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Sidharta Seethana
> Assignee: Sidharta Seethana
> Priority: Minor
> Attachments: YARN-4649.001.patch
>
>
> Adding additional logging to NM container recovery code (specifically
> application/container status operations) makes it easier to debug container
> recovery related issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
