[ 
https://issues.apache.org/jira/browse/YARN-4435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129082#comment-15129082
 ] 

Steve Loughran commented on YARN-4435:
--------------------------------------

# please use .patch as the suffix for ease of viewing/downloading.
# use type {{<T extends TokenIdentifier>}}  instead of just {{<T>}}
# at end of {{addDelegationTokens}}, you should call Yarnclient.stop(). As it 
implements Closeable, you can do this in a try-with-resources call.

As I said in HADOOP-12563, a configuration object needs to be passed down to 
the fetchers. Here you'd then go  {{new YarnConfiguration(conf)}} to force in 
the yarn defaults and site, but still pick up anything on the dt fetcher 
command line that overrides it.

Finally, testing: I don't see any yet. You should be able to add this to an 
existing test with a miniYarnCluster secured with the miniKDC: ask for a token, 
save it to a file, re-read.

> Add RM Delegation Token DtFetcher Implementation for DtUtil
> -----------------------------------------------------------
>
>                 Key: YARN-4435
>                 URL: https://issues.apache.org/jira/browse/YARN-4435
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Matthew Paduano
>            Assignee: Matthew Paduano
>         Attachments: proposed_solution
>
>
> Add a class to yarn project that implements the DtFetcher interface to return 
> a RM delegation token object.  
> I attached a proposed class implementation that does this, but it cannot be 
> added as a patch until the interface is merged in HADOOP-12563



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to