[
https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132611#comment-15132611
]
Sunil G commented on YARN-4386:
-------------------------------
Thanks [~kshukla] for the patch.
I think patch generally cover the intended scenario by covering the changed
code. Looks good. We can wait for [~djp] comments too.
> refreshNodesGracefully() looks at active RMNode list for recommissioning
> decommissioned nodes
> ---------------------------------------------------------------------------------------------
>
> Key: YARN-4386
> URL: https://issues.apache.org/jira/browse/YARN-4386
> Project: Hadoop YARN
> Issue Type: Bug
> Components: graceful
> Affects Versions: 3.0.0
> Reporter: Kuhu Shukla
> Assignee: Kuhu Shukla
> Priority: Minor
> Attachments: YARN-4386-v1.patch, YARN-4386-v2.patch
>
>
> In refreshNodesGracefully(), during recommissioning, the entryset from
> getRMNodes() which has only active nodes (RUNNING, DECOMMISSIONING etc.) is
> used for checking 'decommissioned' nodes which are present in
> getInactiveRMNodes() map alone.
> {code}
> for (Entry<NodeId, RMNode> entry:rmContext.getRMNodes().entrySet()) {
> .........................
> // Recommissioning the nodes
> if (entry.getValue().getState() == NodeState.DECOMMISSIONING
> || entry.getValue().getState() == NodeState.DECOMMISSIONED) {
> this.rmContext.getDispatcher().getEventHandler()
> .handle(new RMNodeEvent(nodeId, RMNodeEventType.RECOMMISSION));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
