[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15133281#comment-15133281
]
Sangjin Lee commented on YARN-4409:
-----------------------------------
I'm not sure what the status of the jenkins result is, but I see the following
as remaining issues:
(checkstyle issues)
-
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/metrics:
missing package-info.java file
- TimelineServiceV2Publisher.java: rmTimelineCollectorManager should be private
- there are quite a few missing javadoc and "first sentence should end with a
period" errors (yarn-api, nodemanager, and resourcemanager)
There are no javadoc errors or findbugs errors from our code as far as I can
tell.
> Fix javadoc and checkstyle issues in timelineservice code
> ---------------------------------------------------------
>
> Key: YARN-4409
> URL: https://issues.apache.org/jira/browse/YARN-4409
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Labels: yarn-2928-1st-milestone
> Attachments: YARN-4409-YARN-2928.01.patch
>
>
> There are a large number of javadoc and checkstyle issues currently open in
> timelineservice code. We need to fix them before we merge it into trunk.
> Refer to
> https://issues.apache.org/jira/browse/YARN-3862?focusedCommentId=15035267&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15035267
> We still have 94 open checkstyle issues and javadocs failing for Java 8.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
