[ 
https://issues.apache.org/jira/browse/YARN-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Naganarasimha G R updated YARN-4654:
------------------------------------
    Attachment: YARN-4654.v1.003.patch

Had an offline discussion with [~rohithsharma] and he was of the opinion that 
test case should fail when the modifications in *RMAdminCLI* is not present 
which was not happening in the patch. IIUC issue was not actually throwing a 
exception but intended behavior was not happening hence modified the test code 
to differ the behavior of CommonNodeLabelsManager when invalid NodeId is sent.

> Yarn node label CLI should parse "=" correctly when trying to remove all 
> labels on a node
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-4654
>                 URL: https://issues.apache.org/jira/browse/YARN-4654
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>         Attachments: YARN-4654.v1.001.patch, YARN-4654.v1.002.patch, 
> YARN-4654.v1.003.patch
>
>
> Currently, when adding labels to nodes, user can run:
> {{yarn rmadmin -replaceLabelsOnNode "host1=x host2=y"}}
> However, when removing labels from a node, user has to run:
> {{yarn rmadmin -replaceLabelsOnNode "host1 host2"}}
> Instead of:
> {{yarn rmadmin -replaceLabelsOnNode "host1= host2="}}
> We should handle both of "=" exists/not-exists case when removing labels on a 
> node.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to