[
https://issues.apache.org/jira/browse/YARN-4465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154303#comment-15154303
]
Sunil G commented on YARN-4465:
-------------------------------
Hi [~bibinchundatt]
Thanks for updating patch. Few comments.:
1. Comment mentioned in {{normalizeAndValidateRequest}} is not correct. Pls
change.
{noformat}
+ // If Node label is not enabled reset request to no label
+ if (null != conf && !YarnConfiguration.areNodeLabelsEnabled(conf)) {
+{noformat}
2. I have a doubt
{code}
// we don't allow specify label expression with more than one node labels
now
if (labelExp != null && labelExp.contains("&&")) {
{code}
In validateResourceRequest, if labelExp contains "&&", exception is thrown.
So do we need to handle special character in {{checkQueueLabelInLabelManager}}
?
3. In {{checkQueueLabelInLabelManager}}, we can remove the statement called
{{str = str.trim();}}
4. test cases are asserting with {{InvalidResourceRequestException}}, but this
patch is now modified to throw {{InvalidLabelResourceRequestException}}. Tests
will pass, but I think we can check this correct exception itself, OR am i
missing something. pls help to correct me.
> SchedulerUtils#validateRequest for Label check should happen only when
> nodelabel enabled
> ----------------------------------------------------------------------------------------
>
> Key: YARN-4465
> URL: https://issues.apache.org/jira/browse/YARN-4465
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Minor
> Attachments: 0001-YARN-4465.patch, 0002-YARN-4465.patch,
> 0003-YARN-4465.patch, 0004-YARN-4465.patch
>
>
> Disable label from rm side yarn.nodelabel.enable=false
> Capacity scheduler label configuration for queue is available as below
> default label for queue = b1 as 3 and accessible labels as 1,3
> Submit application to queue A .
> {noformat}
> Caused by:
> org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.yarn.exceptions.InvalidResourceRequestException):
> Invalid resource request, queue=b1 doesn't have permission to access all
> labels in resource request. labelExpression of resource request=3. Queue
> labels=1,3
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.validateResourceRequest(SchedulerUtils.java:304)
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.normalizeAndValidateRequest(SchedulerUtils.java:234)
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.normalizeAndValidateRequest(SchedulerUtils.java:216)
> at
> org.apache.hadoop.yarn.server.resourcemanager.RMAppManager.validateAndCreateResourceRequest(RMAppManager.java:401)
> at
> org.apache.hadoop.yarn.server.resourcemanager.RMAppManager.createAndPopulateNewRMApp(RMAppManager.java:340)
> at
> org.apache.hadoop.yarn.server.resourcemanager.RMAppManager.submitApplication(RMAppManager.java:283)
> at
> org.apache.hadoop.yarn.server.resourcemanager.ClientRMService.submitApplication(ClientRMService.java:602)
> at
> org.apache.hadoop.yarn.api.impl.pb.service.ApplicationClientProtocolPBServiceImpl.submitApplication(ApplicationClientProtocolPBServiceImpl.java:247)
> {noformat}
> # Ignore default label expression when label is disabled *or*
> # NormalizeResourceRequest we can set label expression to <DEFAULT PARTITION>
> when node label is not enabled *or*
> # Improve message
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
