[
https://issues.apache.org/jira/browse/YARN-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159667#comment-15159667
]
Wangda Tan commented on YARN-4715:
----------------------------------
Hi [~vvasudev],
Thanks for working on the patch, some comments:
- Memory/VCores should not be changeable configuration, otherwise it will
create lots of compatibility issues. So could we handle memory/vcores
separately? We could do:
1) In ResourcePBImpl, don't need to handle configuration missing issue, such as:
{code}
public int getMemory() {
try {
ResourceInformation ri =
this.getResourceInformation(ResourceInformation.MEMORY_MB.getName());
return (int) UnitsConversionUtil
.convert(ri.getUnits(), "M", ri.getValue()).longValue();
} catch (YarnException ye) {
// memory should always be present
initResourcesMap();
return 0;
}
}
{code}
2) Don't need entries for memory/cpu in resource profile xml.
- In initResourcesMap, instead of shutdown the process, could we throw some
special runtime exception? This is a bad issue for a running YARN process, but
may not have to shutdown the process.
- Incompatible resource types between RM/NM/Application need to be handled in
following patches.
> Add support to read resource types from a config file
> -----------------------------------------------------
>
> Key: YARN-4715
> URL: https://issues.apache.org/jira/browse/YARN-4715
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: YARN-4715-YARN-3926.001.patch,
> YARN-4715-YARN-3926.002.patch
>
>
> This ticket is to add support to allow the RM to read the resource types to
> be used for scheduling from a config file. I'll file follow up tickets to add
> similar support in the NM as well as to handle the RM-NM handshake protocol
> issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
