[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173101#comment-15173101
]
Arun Suresh commented on YARN-4719:
-----------------------------------
Much needed patch [~kasha]..
Took a quick look, some comments
# You have an un-used import in the {{FairScheduler}}
# I see that you are triggering the update thread on nodeRemoval too. I
understand this might generally be useful (since the node removal might change
the node ordering), but given this is a refactoring patch, maybe address that
separately ?
# May also be useful to expose functionality in the {{ClusterNodeTracker}} to
give list of nodes in a rack, nodes that match a label expression etc. (This
can possibly be another JIRA too)
> Add a helper library to maintain node state and allows common queries
> ---------------------------------------------------------------------
>
> Key: YARN-4719
> URL: https://issues.apache.org/jira/browse/YARN-4719
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
> Affects Versions: 2.8.0
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: yarn-4719-1.patch, yarn-4719-2.patch
>
>
> The scheduler could use a helper library to maintain node state and allowing
> matching/sorting queries. Several reasons for this:
> # Today, a lot of the node state management is done separately in each
> scheduler. Having a single library will take us that much closer to reducing
> duplication among schedulers.
> # Adding a filtering/matching API would simplify node labels and locality
> significantly.
> # An API that returns a sorted list for a custom comparator would help
> YARN-1011 where we want to sort by allocation and utilization for
> continuous/asynchronous and opportunistic scheduling respectively.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
