[
https://issues.apache.org/jira/browse/YARN-4681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174361#comment-15174361
]
Chris Nauroth commented on YARN-4681:
-------------------------------------
[~je.ik], thank you for updating the patch. I'm +1 for this change, pending a
pre-commit test run from Jenkins. I just clicked the Submit Patch button, so
Jenkins should pick it up now.
However, I'm not confident enough to commit it immediately. I'd like to see
reviews from committers who spend more time in YARN than me. I'd also like to
find out if anyone thinks it should be configurable whether it checks locked or
performs the old calculation. I don't have a sense for how widely people are
dependent on the current smaps checks.
> ProcfsBasedProcessTree should not calculate private clean pages
> ---------------------------------------------------------------
>
> Key: YARN-4681
> URL: https://issues.apache.org/jira/browse/YARN-4681
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.6.0, 2.7.0
> Reporter: Jan Lukavsky
> Assignee: Jan Lukavsky
> Attachments: YARN-4681.patch, YARN-4681.patch
>
>
> ProcfsBasedProcessTree in Node manager calculates memory used by a process
> tree by parsing {{/etc/<pid>/smaps}}, where it calculates {{min(Pss,
> Shared_Dirty) + Private_Dirty + Private_Clean}}. Because not {{mlocked}}
> private clean pages can be reclaimed by kernel, this should be changed to
> calculating only {{Locked}} pages instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
