[
https://issues.apache.org/jira/browse/YARN-4712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naganarasimha G R updated YARN-4712:
------------------------------------
Attachment: YARN-4712-YARN-2928.v1.002.patch
Hi [~varun_saxena],
bq. I was incorrectly assuming that CPU % is reported to NMTimelinePublisher in
the range of 0-1. This doesn't seem to be the case though.
You are right even i tested it i was able to to get more than cores as
percentage. so multiplying with 100 is not required and even i felt *round* is
better than floor have incorporated the required changes.
bq. 2 of the checkstyle issues seem fixable.
Well have corrected it but i generally use the eclipse formatter which follows
the sun conventions as mentioned in the [Hadoop
wiki|https://wiki.apache.org/hadoop/HowToContribute] , so usually eclipse
formatter takes care of 80 chars per line effectively where ever possible but
is required to do additionally apart from it? cc/ [~sjlee0]
> CPU Usage Metric is not captured properly in YARN-2928
> ------------------------------------------------------
>
> Key: YARN-4712
> URL: https://issues.apache.org/jira/browse/YARN-4712
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Labels: yarn-2928-1st-milestone
> Attachments: YARN-4712-YARN-2928.v1.001.patch,
> YARN-4712-YARN-2928.v1.002.patch
>
>
> There are 2 issues with CPU usage collection
> * I was able to observe that that many times CPU usage got from
> {{pTree.getCpuUsagePercent()}} is
> ResourceCalculatorProcessTree.UNAVAILABLE(i.e. -1) but ContainersMonitor do
> the calculation i.e. {{cpuUsageTotalCoresPercentage = cpuUsagePercentPerCore
> /resourceCalculatorPlugin.getNumProcessors()}} because of which UNAVAILABLE
> check in {{NMTimelinePublisher.reportContainerResourceUsage}} is not
> encountered. so proper checks needs to be handled
> * {{EntityColumnPrefix.METRIC}} uses always LongConverter but
> ContainerMonitor is publishing decimal values for the CPU usage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
