[
https://issues.apache.org/jira/browse/YARN-4749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178053#comment-15178053
]
Varun Vasudev commented on YARN-4749:
-------------------------------------
Thanks for the patch [~sidharta-s]. It looks mostly good. One
formatting/indentation fix -
{code}
+ if(cfg->confdetails[cfg->size] )
+ cfg->size++;
{code}
Please fix the formatting of the if condition, and fix the indentation of the
the increment statement. I would prefer it if you added braces but that's my
personal choice.
> Generalize config file handling in container-executor
> -----------------------------------------------------
>
> Key: YARN-4749
> URL: https://issues.apache.org/jira/browse/YARN-4749
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Sidharta Seethana
> Assignee: Sidharta Seethana
> Attachments: YARN-4749.001.patch
>
>
> The current implementation of container-executor already supports parsing of
> key value pairs from a config file. However, it is currently restricted to
> {{container-executor.cfg}} and cannot be reused for parsing additional
> config/command files. Generalizing this is a required step for YARN-4245.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
