[
https://issues.apache.org/jira/browse/YARN-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185986#comment-15185986
]
Wangda Tan commented on YARN-4634:
----------------------------------
[~sunilg],
It seems:
{code}
if (null == nodeLabelsInfo || (nodeLabelsInfo.size() == 1
+ && nodeLabelsInfo.get(0).getLabelName().isEmpty())
+ || !hasAnyLabelLinkedToNM) {
{code}
Can be simplified to:
{code}
if (!hasAnyLabelLinkedToNM) ...
{code}
Correct?
> Scheduler UI/Metrics need to consider cases like non-queue label mappings
> -------------------------------------------------------------------------
>
> Key: YARN-4634
> URL: https://issues.apache.org/jira/browse/YARN-4634
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.7.1
> Reporter: Sunil G
> Assignee: Sunil G
> Attachments: 0001-YARN-4634.patch, 0002-YARN-4634.patch,
> 0003-YARN-4634.patch, 0004-YARN-4634.patch
>
>
> Currently when label-queue mappings are not available, there are few
> assumptions taken in UI and in metrics.
> In above case where labels are enabled and available in cluster but without
> any queue mappings, UI displays queues under labels. This is not correct.
> Currently labels enabled check and availability of labels are considered to
> render scheduler UI. Henceforth we also need to check whether
> - queue-mappings are available
> - nodes are mapped with labels with proper exclusivity flags on
> This ticket also will try to see the default configurations in queue when
> labels are not mapped.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
