[ 
https://issues.apache.org/jira/browse/YARN-4738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186743#comment-15186743
 ] 

Arun Suresh commented on YARN-4738:
-----------------------------------

Thanks for the patch [~kkaranasos]. Took a first pass at it.. Couple of comments

* In line 565, It looks like the {{containerId}} is being removed from the 
map.. shouldnt it be the {{containerTokenId}} ?
* in line 608, w.r.t the TODO... yes, we should send the killed queued 
containers info during Node registration as well as re-registration.
* The {{TestNodeStatusUpdater}} should include a testcase verify this new 
information is sent and received  at the RM. 


> Notify the RM about the status of OPPORTUNISTIC containers
> ----------------------------------------------------------
>
>                 Key: YARN-4738
>                 URL: https://issues.apache.org/jira/browse/YARN-4738
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Konstantinos Karanasos
>            Assignee: Konstantinos Karanasos
>         Attachments: YARN-4738-yarn-2877.001.patch
>
>
> When an OPPORTUNISTIC container finishes its execution (either successfully 
> or because it failed/got killed), the RM needs to be notified.
> This way the AM also gets notified in turn about the successfully completed 
> tasks, as well as for rescheduling failed/killed tasks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to