[
https://issues.apache.org/jira/browse/YARN-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189960#comment-15189960
]
Jian He commented on YARN-4117:
-------------------------------
looks good to me, just some minor nits:
- I think these two methods are not needed, as it can just use the
amrmProxyEnabled flag directly
{code}
@Private
public boolean isAMRMProxyEnabled() {
return amrmProxyEnabled;
}
@Private
public void setAMRMProxyEnabled(boolean amrmProxyEnabled)
{
this.amrmProxyEnabled = amrmProxyEnabled;
}
{code}
- change the visibility to protected.
{code}
@Private
public void setAMRMProxyService(AMRMProxyService amrmProxyService) {
this.amrmProxyService = amrmProxyService;
}
{code}
> End to end unit test with mini YARN cluster for AMRMProxy Service
> -----------------------------------------------------------------
>
> Key: YARN-4117
> URL: https://issues.apache.org/jira/browse/YARN-4117
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager, resourcemanager
> Reporter: Kishore Chaliparambil
> Assignee: Giovanni Matteo Fumarola
> Attachments: YARN-4117.v0.patch, YARN-4117.v1.patch,
> YARN-4117.v2.patch
>
>
> YARN-2884 introduces a proxy between AM and RM. This JIRA proposes an end to
> end unit test using mini YARN cluster to the AMRMProxy service. This test
> will validate register, allocate and finish application and token renewal.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
