[
https://issues.apache.org/jira/browse/YARN-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15191508#comment-15191508
]
Naganarasimha G R commented on YARN-4545:
-----------------------------------------
Hi [~gtCarrera],
Overall approach is fine and having the method in TimelineUtils is better
approach and Some small nits :-
# In ApplicationMaster getConf has default acccess and has following
annotations : @VisibleForTesting & @Private, i checked the reference and seems
like not used any where apart from NMCallbackHandler, so i think it can be set
as private and we can remove the annotations
# {{publishContainerStartEvent}} is kept as static and private so that it can
be made accessible from static class NMCallbackHandler, but we have the
reference of ApplicationMaster so i dont feel we need to make it static we can
call through the reference directly and thus we need not get the conf object in
NMCallbackHandler and add additional argument in {{publishContainerStartEvent}}.
# Seems like similar nits exist for all static methods i dont see any necessity
for static methods as RMCallbackHandler is *not* static inner class and even if
required it would be better to have reference to ApplicationMaster.
# There seems to be findbugs issue either we need to add it findbugs exclude
file or better to remove {{private Configuration configuration}} as its
available from get parent by using *getConfig*
# some of the checkstyle issues (like line greater than 80 chars can be fixed)
> Allow YARN distributed shell to use ATS v1.5 APIs
> -------------------------------------------------
>
> Key: YARN-4545
> URL: https://issues.apache.org/jira/browse/YARN-4545
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Li Lu
> Assignee: Li Lu
> Attachments: YARN-4545-YARN-4265.001.patch,
> YARN-4545-trunk.001.patch, YARN-4545-trunk.002.patch,
> YARN-4545-trunk.003.patch, YARN-4545-trunk.004.patch,
> YARN-4545-trunk.005.patch, YARN-4545-trunk.006.patch,
> YARN-4545-trunk.007.patch
>
>
> We can use YARN distributed shell as a demo for the ATS v1.5 APIs. We need to
> allow distributed shell post data with ATS v1.5 API if 1.5 is enabled in the
> system. We also need to provide a sample plugin to read those data out.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
