[
https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192416#comment-15192416
]
Karthik Kambatla commented on YARN-4807:
----------------------------------------
Actually, the problem seems worse. We have multiple {{waitForState}} methods in
MockRM - for app, appattempt, container. There is some duplication there, but
what is worse each method has its own sleepTime and cumulative_wait_time. It
would be nice to use a constant for sleep time instead of hard coded values.
If it is not a problem, I would like for us to start with a really small value
like 10 ms. It seems to be working for one of the {{waitForState}} methods in
MockRM.
Regarding removing MockAM#waitForState methods altogether, I am not so sure if
that will be straight-forward or desired. I have seen test cases where there is
no reference to an RM or MockRM.
> MockAM#waitForState sleep duration is too long
> ----------------------------------------------
>
> Key: YARN-4807
> URL: https://issues.apache.org/jira/browse/YARN-4807
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.8.0
> Reporter: Karthik Kambatla
> Assignee: Yufei Gu
> Labels: newbie
>
> MockAM#waitForState sleep duration (500 ms) is too long. Also, there is
> significant duplication with MockRM#waitForState.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
